Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge #3719 into feature branch #3730

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Merge #3719 into feature branch #3730

merged 3 commits into from
Jan 22, 2025

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jan 22, 2025 •
edited
Loading

Description

#3719 should have been merged into the feature branch instead of the user branch.

Also fix the instruction pretty printing tests (changes seem to have been introduced in #3718).

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent
document effects on value stack and control stack
a474836
@turbolent
Merge pull request #3719 from onflow/bastian/document-effects
ed25841 
[Compiler+VM POC] Document effects of instructions on value stack and control stack
@turbolent turbolent requested a review from jsproz January 22, 2025 17:04
@turbolent turbolent self-assigned this Jan 22, 2025
@turbolent turbolent requested a review from SupunS as a code owner January 22, 2025 17:04
@github-actions GitHub Actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit a24debb
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent
Copy link
Member Author

@SupunS is the timeout of TestRecursionFib and the linting errors expected for now?

@SupunS
Copy link
Member

SupunS commented Jan 22, 2025

Linting errors are expected for now. But not sure why TestRecursionFib times out; Runs fine locally

SupunS
SupunS approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timeout happens for other PRs as well. e.g: #3727

Would need to have a look at that separately. Shouldn't be a blocker for this PR.

@turbolent turbolent merged commit c942246 into feature/compiler Jan 22, 2025
6 of 9 checks passed
@turbolent turbolent deleted the supun/vm-cadence-1.0 branch January 22, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@jsproz jsproz Awaiting requested review from jsproz

Assignees

@turbolent turbolent

Labels
Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @SupunS